Skip to content

🌐 i18n: add new notification message and close text to translation files #563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 9, 2023
Merged

🌐 i18n: add new notification message and close text to translation files #563

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7e22a60
🚀 chore(package.json): update @appquality/unguess-design-system to ve…
marcbon May 9, 2023
ff02fc0
🌐 i18n: add new notification message and close text to translation files
marcbon May 9, 2023
e93a7a8
📝 docs(translation.json): add message to confirm close header in expr…
marcbon May 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"version": "1.4.0",
"private": true,
"dependencies": {
"@appquality/unguess-design-system": "2.12.85",
"@appquality/unguess-design-system": "2.12.86",
"@headwayapp/react-widget": "^0.0.4",
"@reduxjs/toolkit": "^1.8.0",
"@rtk-query/codegen-openapi": "^1.0.0-alpha.1",
Expand Down
2 changes: 1 addition & 1 deletion src/app/App.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ const App = () => {
</Helmet>
<ToastProvider
limit={5}
zIndex={theme.levels.front}
zIndex={theme.levels.modal}
placementProps={{
top: {
style: {
Expand Down
17 changes: 17 additions & 0 deletions src/features/navigation/Navigation.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@ import {
Sidebar,
ProfileModal,
theme,
useToast,
Notification,
} from '@appquality/unguess-design-system';
import { useTranslation } from 'react-i18next';
import { useAppDispatch, useAppSelector } from 'src/app/hooks';
Expand Down Expand Up @@ -46,6 +48,7 @@ export const Navigation = ({
const { isSidebarOpen, activeWorkspace } = useAppSelector(
(state) => state.navigation
);
const { addToast } = useToast();

// Set isSidebarOpen to false for specific routes
useEffect(() => {
Expand Down Expand Up @@ -177,6 +180,20 @@ export const Navigation = ({
onLogout: async () => {
await WPAPI.logout();
},
onCopyEmail: () => {
addToast(
({ close }) => (
<Notification
onClose={close}
type="success"
message={t('__NOTIFICATION_PROFILE_MODAL_COPY_EMAIL_MESSAGE')}
closeText={t('__NOTIFICATION_CLOSE_TEXT')}
isPrimary
/>
),
{ placement: 'top' }
);
},
};

const navigateTo = (requiredRoute: string, routeParameter?: string) => {
Expand Down
10 changes: 6 additions & 4 deletions src/locales/en/translation.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -464,14 +464,14 @@
"__EXPRESS_LABEL": "Express",
"__EXPRESS_WIZARD_BACK_BUTTON_LABEL": "Back",
"__EXPRESS_WIZARD_CONFIRM_BUTTON_LABEL": "Launch",
"__EXPRESS_WIZARD_CONFIRM_CLOSE_HEADER": "Are you sure you want to quit this campaign?",
" ": "If you quit now, your changes will be lost and you’ll have to restart.",
"__EXPRESS_WIZARD_CONFIRM_CLOSE_CANCEL_BUTTON_TEXT": "Quit and discard",
"__EXPRESS_WIZARD_CONFIRM_CLOSE_CONTINUE_BUTTON_TEXT": "Continue editing",
"__EXPRESS_WIZARD_CONFIRM_DELETE_USE_CASE_HEADER": "Are you sure to delete?",
"__EXPRESS_WIZARD_CONFIRM_CLOSE_HEADER": "Are you sure you want to quit this campaign?",
"__EXPRESS_WIZARD_CONFIRM_CLOSE_MESSAGE": "If you quit now, your changes will be lost and you’ll have to restart.",
"__EXPRESS_WIZARD_CONFIRM_DELETE_USE_CASE": "If you delete it, you will lose all the informations you have entered.",
"__EXPRESS_WIZARD_CONFIRM_DELETE_USE_CASE_BUTTON_DELETE": "Delete",
"__EXPRESS_WIZARD_CONFIRM_DELETE_USE_CASE_BUTTON_CONTINUE": "Continue",
"__EXPRESS_WIZARD_CONFIRM_DELETE_USE_CASE_BUTTON_DELETE": "Delete",
"__EXPRESS_WIZARD_CONFIRM_DELETE_USE_CASE_HEADER": "Are you sure to delete?",
"__EXPRESS_WIZARD_CONFIRM_PLANNING_BUTTON_LABEL": "Plan",
"__EXPRESS_WIZARD_NEXT_BUTTON_LABEL": "Next",
"__EXPRESS_WIZARD_STEP_APP_WHERE_OS_ANDROID_LABEL": "Android",
Expand Down Expand Up @@ -636,6 +636,8 @@
"__LOGIN_FORM_PASSWORD_FORGOT_LABEL": "Forgot your password?",
"__LOGIN_FORM_PASSWORD_PLACEHOLDER": "Insert your password",
"__LOGIN_FORM_TITLE": "Log in to UNGUESS",
"__NOTIFICATION_CLOSE_TEXT": "Dismiss",
"__NOTIFICATION_PROFILE_MODAL_COPY_EMAIL_MESSAGE": "Email address copied to clipboard",
"__PAGE_BUG_EMPTY_STATE_CTA": "Try another search",
"__PAGE_BUG_SEARCH_EMPTY_STATE_MAIN_GENERIC": "There are no results for this keyword",
"__PAGE_BUG_SEARCH_EMPTY_STATE_SUB": "Try different or more general keywords",
Expand Down
10 changes: 6 additions & 4 deletions src/locales/it/translation.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -477,14 +477,14 @@
"__EXPRESS_LABEL": "Express",
"__EXPRESS_WIZARD_BACK_BUTTON_LABEL": "Indietro",
"__EXPRESS_WIZARD_CONFIRM_BUTTON_LABEL": "Lancia",
"__EXPRESS_WIZARD_CONFIRM_CLOSE_HEADER": "Vuoi abbandonare la campagna?",
"__EXPRESS_WIZARD_CONFIRM_CLOSE_MESSAGE": "Se esci ora, perderai i dati inseriti e dovrai iniziare da capo.",
"__EXPRESS_WIZARD_CONFIRM_CLOSE_CANCEL_BUTTON_TEXT": "Esci ed elimina",
"__EXPRESS_WIZARD_CONFIRM_CLOSE_CONTINUE_BUTTON_TEXT": "Torna alla campagna",
"__EXPRESS_WIZARD_CONFIRM_DELETE_USE_CASE_HEADER": "Sei sicuro di eliminare?",
"__EXPRESS_WIZARD_CONFIRM_CLOSE_HEADER": "Vuoi abbandonare la campagna?",
"__EXPRESS_WIZARD_CONFIRM_CLOSE_MESSAGE": "Se esci ora, perderai i dati inseriti e dovrai iniziare da capo.",
"__EXPRESS_WIZARD_CONFIRM_DELETE_USE_CASE": "Se lo elimini, perderai tutte le informazioni inserite.",
"__EXPRESS_WIZARD_CONFIRM_DELETE_USE_CASE_BUTTON_DELETE": "Eliminare",
"__EXPRESS_WIZARD_CONFIRM_DELETE_USE_CASE_BUTTON_CONTINUE": "Continuare",
"__EXPRESS_WIZARD_CONFIRM_DELETE_USE_CASE_BUTTON_DELETE": "Eliminare",
"__EXPRESS_WIZARD_CONFIRM_DELETE_USE_CASE_HEADER": "Sei sicuro di eliminare?",
"__EXPRESS_WIZARD_CONFIRM_PLANNING_BUTTON_LABEL": "Pianifica",
"__EXPRESS_WIZARD_NEXT_BUTTON_LABEL": "Avanti",
"__EXPRESS_WIZARD_STEP_APP_WHERE_OS_ANDROID_LABEL": "Android",
Expand Down Expand Up @@ -649,6 +649,8 @@
"__LOGIN_FORM_PASSWORD_FORGOT_LABEL": "Password dimenticata?",
"__LOGIN_FORM_PASSWORD_PLACEHOLDER": "Inserisci password",
"__LOGIN_FORM_TITLE": "Entra in UNGUESS",
"__NOTIFICATION_CLOSE_TEXT": "Chiudi",
"__NOTIFICATION_PROFILE_MODAL_COPY_EMAIL_MESSAGE": "Hai copiato l’indirizzo email",
"__PAGE_BUG_EMPTY_STATE_CTA": "Fai una nuova ricerca",
"__PAGE_BUG_SEARCH_EMPTY_STATE_MAIN_GENERIC": "Non ci sono risultati per questa parola chiave",
"__PAGE_BUG_SEARCH_EMPTY_STATE_SUB": "Prova con parole chiave diverse o più comuni",
Expand Down
8 changes: 4 additions & 4 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,10 +47,10 @@
ajv-draft-04 "^1.0.0"
call-me-maybe "^1.0.1"

"@appquality/unguess-design-system@2.12.85":
version "2.12.85"
resolved "https://registry.yarnpkg.com/@appquality/unguess-design-system/-/unguess-design-system-2.12.85.tgz#2728958f3582c5192d5be1f6b313556def6c7cdc"
integrity sha512-UScNYFfwnLed/Xnin8ylPeqpLktRfBxTIPr9DaqMn2nqUpGxDkVN+cGzx3jxChir0mvRnkzolQD8S49ueQoCFA==
"@appquality/unguess-design-system@2.12.86":
version "2.12.86"
resolved "https://registry.yarnpkg.com/@appquality/unguess-design-system/-/unguess-design-system-2.12.86.tgz#5c12a23c0de08a58e1ba48ddfeed01f7974c2d9e"
integrity sha512-apmO18nrmyF0BWwMXWqTaz0he0Jel0eO2A/DrJs0IMtEGwIKeVe4tJJ8JA4uzmJMp9Fml7Hl8SIk2N23wlCU/w==
dependencies:
"@nivo/bar" "^0.80.0"
"@nivo/bullet" "^0.80.0"
Expand Down