UN-557-anchor-buttons #482
Conversation
| @@ -1,3 +1,4 @@ | |||
| import { Dispatch, SetStateAction } from 'react'; | |||
| import { LG, Tabs } from '@appquality/unguess-design-system'; | |||
There was a problem hiding this comment.
"Dispatch", "SetStateAction" are not used, there are 2 warnings. Remember to run yarn validate to see if there are any issues.
Also I suggest to use also the scripts format:check and format:fix for formatting purposes. Check package.json
| import styled from 'styled-components'; | ||
| import { theme as globalTheme } from 'src/app/theme'; | ||
| import { ReactComponent as DetailsIcon } from 'src/assets/icons/details-icon.svg'; | ||
| import { Dispatch, SetStateAction } from 'react'; |
| import { useGetCampaignsByCidBugsAndBidQuery } from 'src/features/api'; | ||
| import { getSelectedBugId } from 'src/features/bugsPage/bugsPageSlice'; | ||
| import { useEffect, useRef } from 'react'; | ||
| import { Dispatch, SetStateAction, useEffect, useRef, useState } from 'react'; |
|
|
||
| const AnchorButtons = (): ReactElement => ( | ||
| <FlexComponent> | ||
| <Link |
There was a problem hiding this comment.
All the controls if the relative sections are visible are missing. So in this case for example you will see the attachments anchor even if the attachments section is hidden (no media).
Remember to check and implement the same behavior that we set to show/hide all the sections
| import { useGetCampaignsByCidBugsAndBidQuery } from 'src/features/api'; | ||
| import { getSelectedBugId } from 'src/features/bugsPage/bugsPageSlice'; | ||
| import { useEffect, useRef } from 'react'; | ||
| import AnchorButtons from 'src/common/components/AnchorButtons'; |
There was a problem hiding this comment.
this component AnchorButtons should be moved inside the BugDetail folder, just to be more clear since it's related to that component
sinatragianpaolo
temporarily deployed
to
Staging
GitHub Actions
Inactive
corneliogiansenio
temporarily deployed
to
Staging
GitHub Actions
Inactive
Anchor Scroll buttons added.