Skip to content

feat(filters): add disabled check to page filters #445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 3, 2023
Merged

feat(filters): add disabled check to page filters #445

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/pages/Bugs/Filters/ReadFilter.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,14 +11,17 @@ import {
} from 'src/features/bugsPage/bugsPageSlice';
import { useTranslation } from 'react-i18next';
import { useAppDispatch } from 'src/app/hooks';
import { useFilterData } from '../Drawer/useFilterData';

export const ReadFilter = () => {
const dispatch = useAppDispatch();
const data = getCurrentCampaignData();
const { counters } = useFilterData('read');
const { t } = useTranslation();

if (
!data ||
!counters ||
!data.read ||
!data.read.available ||
!data.read.available.length
Expand Down Expand Up @@ -48,7 +51,7 @@ export const ReadFilter = () => {
</Field>
<Menu>
{data.read.available.map((item) => (
<Item value={item}>
<Item value={item} disabled={!counters[item as string]}>
{item === 'unread'
? t('__BUGS_READ_FILTER_ITEM_UNREAD')
: t('__BUGS_READ_FILTER_ITEM_ALL')}
Expand Down
4 changes: 4 additions & 0 deletions src/pages/Bugs/Filters/SeverityFilter.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,17 @@ import {
} from 'src/features/bugsPage/bugsPageSlice';
import { useTranslation } from 'react-i18next';
import { useAppDispatch } from 'src/app/hooks';
import { useFilterData } from '../Drawer/useFilterData';

export const SeverityFilter = () => {
const dispatch = useAppDispatch();
const data = getCurrentCampaignData();
const { counters } = useFilterData('severities');
const { t } = useTranslation();

if (
!data ||
!counters ||
!data.severities ||
!data.severities.available ||
!data.severities.available.length
Expand Down Expand Up @@ -42,6 +45,7 @@ export const SeverityFilter = () => {
options={data.severities.available.map((item) => ({
itemId: item.id,
label: item.name,
disabled: !counters[item.id],
selected: data.severities.selected.map((i) => i.id).includes(item.id),
}))}
/>
Expand Down
5 changes: 4 additions & 1 deletion src/pages/Bugs/Filters/UniqueFilter.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,14 +11,17 @@ import {
} from 'src/features/bugsPage/bugsPageSlice';
import { useTranslation } from 'react-i18next';
import { useAppDispatch } from 'src/app/hooks';
import { useFilterData } from '../Drawer/useFilterData';

export const UniqueFilter = () => {
const dispatch = useAppDispatch();
const data = getCurrentCampaignData();
const { counters } = useFilterData('unique');
const { t } = useTranslation();

if (
!data ||
!counters ||
!data.unique ||
!data.unique.available ||
!data.unique.available.length
Expand Down Expand Up @@ -48,7 +51,7 @@ export const UniqueFilter = () => {
</Field>
<Menu>
{data.unique.available.map((item) => (
<Item value={item}>
<Item value={item} disabled={!counters[item as string]}>
{item === 'unique'
? t('__BUGS_UNIQUE_FILTER_ITEM_UNIQUE')
: t('__BUGS_UNIQUE_FILTER_ITEM_ALL')}
Expand Down