Skip to content

Un 468 item order #417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 30, 2023
Merged

Un 468 item order #417

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b3f57e8
fix(bugs-table): table item order by API
iacopolea Jan 30, 2023
cdbb424
chore: remove unused file
iacopolea Jan 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 3 additions & 8 deletions src/pages/Bugs/BugsTable/hooks/useTableData.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ import { useCampaignSeverities } from './useCampaignSeverities';
import { useCampaignUseCases } from './useCampaignUseCases';
import { sortBySeverity } from '../utils/sortBySeverity';
import { sortByUseCase } from '../utils/sortByUseCase';
import { sortById } from '../utils/sortById';

export const useTableData = (campaignId: number) => {
// get bugs accepted severities and usecases
Expand Down Expand Up @@ -35,18 +34,14 @@ export const useTableData = (campaignId: number) => {
}

const bugsBySeverity = sortBySeverity(bugs.items, severities);
const bugsByUsecase = sortByUseCase(bugs.items, useCases);
const bugsByUseCases = sortByUseCase(bugs.items, useCases);

/* got the data */
return {
data: {
allBugs: bugs.items,
bugsByUseCases: bugsByUsecase.sort((a, b) =>
sortById(a.useCase.id, b.useCase.id)
),
bugsBySeverity: bugsBySeverity.sort((a, b) =>
sortById(a.severity.id, b.severity.id, 'DESC')
),
bugsByUseCases,
bugsBySeverity,
},
isLoading: false,
error: bugsError || severitiesError || useCasesError,
Expand Down
13 changes: 0 additions & 13 deletions src/pages/Bugs/BugsTable/utils/sortById.ts
View file
Open in desktop

This file was deleted.