Un 152 flip card #283
Merged
Un 152 flip card #283
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcbon
reviewed
Nov 25, 2022
| <FlipCard.Header>Header</FlipCard.Header> | ||
| <FlipCard.Body | ||
| // height='300px' | ||
| front={ |
Collaborator
There was a problem hiding this comment.
a sto punto non veniva più pulito fare anche front e back come sotto componenti?
marcbon
requested changes
Nov 25, 2022
src/pages/Campaign/widgets/widgetCards/FlipCard/FlipCardHeader.tsx
Outdated
Show resolved
Hide resolved
cannarocks
reviewed
Nov 25, 2022
Member
cannarocks
left a comment
cannarocks
left a comment
There was a problem hiding this comment.
@iacopolea in generale mi sembra un ottimo lavoro, resta solo qualche dubbio sui children dolly soprattutto in termini di leggibilità e manutenibilità.
src/pages/Campaign/widgets/widgetCards/FlipCard/FlipCardHeader.tsx
Outdated
Show resolved
Hide resolved
marcbon
approved these changes
Nov 28, 2022
iacopolea
force-pushed
the
UN-152-switchable-card
branch
from
f60e186 to
a2c5b13
Compare
Member
Author
|
rebasato su develop per eliminare i conflitti |
cannarocks
reviewed
Nov 28, 2022
src/pages/Campaign/widgets/widgetCards/FlipCard/FlipCardContext.ts
Outdated
Show resolved
Hide resolved
cannarocks
reviewed
Nov 28, 2022
| export const useFlipCardContext = () => { | ||
| const context = useContext(FlipCardContext); | ||
|
|
||
| if (!context) |
Member
There was a problem hiding this comment.
Questo controllo qua mi permette di avere il null come default e di non preoccuparmene lato sviluppo (perché ts sa che sarà sempre valorizzato). Dovessi fare un'altra card con lo stesso contesto oppure utilizzarlo dimenticandomi il provider avrò subito un errore visibile.
cannarocks
approved these changes
Nov 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flip card e refactor widget cards con componenti generici