-
Notifications
You must be signed in to change notification settings - Fork 1
feat(campaign-reports): add integration center call to action for empty state #258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bug fixes
… dashboard (#254) * chore(design-system): update design system version * chore(design-system): update design library with sidebar fixes * feat(login-page): add navigate state in order to handle afterLogin In logged template add new state var with the current location value. This value will be used to redirect back the user after a correct login * test(login): add debug log * fix(login-form): update redirect method * feat(campaign-dashboard): setup basic page * chore(api): update api slice with get-campaign-reports route * feat(campaign-dashboard): retrieve reports from api * chore(api): update api hooks with getCampaignById * feat(campaign-dashboard): create barebone structure * feat(dashboard-routing): clean up dashboard routing with a clean new util * chore(api): update api definition * Cup 1334 add report dashboard (#240) * feat(campaign-dashboard): setup basic page * chore(api): update api slice with get-campaign-reports route * feat(campaign-dashboard): retrieve reports from api * chore(api): update api hooks with getCampaignById * feat(campaign-dashboard): create barebone structure * feat(campaign-dashboard): add new UI for report cards * feat(campaign-reports): add new archive icon * feat(translations): add missing download label for campaign reports * feat(translations): update campaign reports translations * feat(campaign-reports): add input toggle in page header * fix(campaing-dashboard): input toggle is not editable * feat(campaign-reports): improve campaign page and page header components * feat(campaign-reports): add empty state * feat(campaign-reports): add page title and subtitle * feat(campaign-reports): add translations for file type labels * feat(campaign-reports): handle different button text and icon for links + remove trim input * fix(campaign-reports): fix date font size Co-authored-by: Luca Cannarozzo <cannarozzoluca@live.it> * feat(dashboard): redirect campaign to the most appropriate dash * fix(campaign-reports): fix breadcrumb project href + fix empty state title * build(gtm): change Google Tag Manager container * feat(gtm): add auth and env to dev gtm environment * test(gtm): remove pageView event * feat(campaign-reports): add loader + page improvements * feat(routes): add CROWD_WP_URL to localized routes paths * fix(wizard): fix missing campaign_date_end * fix(wizard): remove useless campaign_date_end_text form field * fix(wizard): remove useless whenConfirm old component * feat(gtm): move dl push into useEffect hook * Update translation.json (POEditor.com) * Update translation.json (POEditor.com) * refactor(i18n): reordered terms * refactor(i18n): remove unused term * Update translation.json (POEditor.com) * Update translation.json (POEditor.com) * sort terms * fix(translations): update translations + fix i18n compare * Update translation.json (POEditor.com) * Update translation.json (POEditor.com) * refactor(i18n): re-ordered strings * chore(design-system): bump version to fix sidebar on mobile * refactor(express): remove unused import on who step * feat(express): improve mobile experience with modal use case * feat(express): improve experience of submit btn on small screen * fix(gtm): check activeWorkspace before setting DL company * fix(gtm): update company also on ws switch * feat(gtm): add workspace change event * refactor(navigation): remove useless console log Co-authored-by: Marco Bonomo <82754802+marcbon@users.noreply.github.com> Co-authored-by: Marco Bonomo <marco.bonomo@unguess.io>
cannarocks
requested changes
Oct 10, 2022
Member
cannarocks
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Manca il controllo sulla "funzionalità" della cp corrente (si tratta di un semplice if) e c'è da controllare bene l'immagine che è sì più piccola ma si porta dietro un marginazzo destro che può creare scompiglio con gli allineamenti
cannarocks
approved these changes
Oct 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.