Skip to content

Conversation

@Kariamos
Copy link
Contributor

@Kariamos Kariamos commented Aug 25, 2025

resolves UN-1697

@sentry
Copy link

sentry bot commented Aug 25, 2025

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: src/pages/JoinPage/useJoinSubmit.tsx

Function Unhandled Issue
useJoinSubmit TypeError: useSearchParams(...).get is not a function ...
Event Count: 1 Affected Users: 1

Did you find this useful? React with a 👍 or 👎

@Kariamos Kariamos marked this pull request as ready for review August 25, 2025 10:27
@Kariamos Kariamos requested a review from Copilot August 25, 2025 12:36
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a bug where the templateId parameter from URL search parameters was not being included in the form submission data. The fix parses the template parameter from the URL, validates it as an integer, and conditionally includes it in the basicInfo object during join form submission.

  • Added URL parameter parsing for the 'template' query parameter
  • Implemented validation to ensure template parameter is a valid integer
  • Included templateId in the basicInfo object when submitting the form

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Kariamos Kariamos merged commit ec0baf4 into develop Aug 25, 2025
11 checks passed
@Kariamos Kariamos deleted the join-page-template-id branch August 25, 2025 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants