Skip to content

UN-2077-mobile-notification #559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

UN-2077-mobile-notification #559

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3431671
fix: Update notification message for clarity and enhance mobile respo…
marcbon Nov 20, 2025
7dfd21d
fix: Add close text prop to notifications and adjust close button sty…
marcbon Nov 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/stories/notifications/index.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,9 @@ interface NotificationStoryProps {
const defaultArgs: NotificationStoryProps = {
notificationArgs: {
type: "info",
message: "Action completed",
message: "Action completed for this kind of notification.",
onClose: () => alert("Close"),
closeText: "Close notification",
},
toastProviderArgs: {
limit: 5,
Expand Down
35 changes: 32 additions & 3 deletions src/stories/notifications/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ const UgAnchor = styled(Anchor).attrs<{
${(props) => retrieveComponentStyles(CLOSE_COMPONENT_ID, props)};
`;

const UgTitle = styled(Title).attrs<{
const UgTitle = styled(Title).attrs<{
"data-custom-id"?: string
}>((props) => ({
"data-custom-id": props["data-custom-id"] ?? TITLE_COMPONENT_ID,
Expand All @@ -59,6 +59,36 @@ const UgNotification = styled(ZendeskNotification)<NotificationArgs>`
}

${(props) => retrieveComponentStyles(NOTIFICATION_COMPONENT_ID, props)};

@media screen and (max-width: ${({ theme }) => theme.breakpoints.sm}) {
flex-direction: column;
padding: ${({ theme }) => theme.space.md};
width: 300px; // Set a fixed width for better mobile appearance
white-space: normal;
justify-content: center;

> svg {
display: none;
}

${({ closeText, theme }) => !closeText && `
a[data-custom-id="notifications.notification.close"] {
margin: 0;
position: absolute;
top: ${theme.space.xxs};
right: ${theme.space.xxs};
}
`}

${UgTitle} {
text-align: center;
}

${UgAnchor} {
margin: auto;
margin-top: ${({ theme }) => theme.space.sm};
}
}
`;

/**
Expand All @@ -68,7 +98,6 @@ const UgNotification = styled(ZendeskNotification)<NotificationArgs>`
- For a passive status update about user or system activity
*/
const Notification = ({
closeText,
message,
onClose,
type,
Expand All @@ -81,7 +110,7 @@ const Notification = ({
{message}
</UgTitle>
<UgAnchor type={type} isPrimary={isPrimary} onClick={onClose}>
{closeText ?? <UgClose />}
{props.closeText ?? <UgClose />}
</UgAnchor>
</UgNotification>
);
Expand Down