Can't build google chrome

[Alex-Farol]

Hi!

I was trying to build the Chrome Appimage but always get stuck in a message saying that cp can't find google-chrome-stable_current_amd64.deb, although it exists inside directory created by pkg2appimage. I noticed that the path it searchs is duplicated, but I don't know how to fix it.

That's the last messages I get:

> Starting pkgProblemResolver with broken count: 0
> Starting 2 pkgProblemResolver with broken count: 0
> Done
> + FILES=/home/ubuntu/google-chrome//home/ubuntu/google-chrome/google-chrome-stable_current_amd64.deb
> + '[' '!' -z /home/ubuntu/google-chrome//home/ubuntu/google-chrome/google-chrome-stable_current_amd64.deb ']'
> + echo /home/ubuntu/google-chrome//home/ubuntu/google-chrome/google-chrome-stable_current_amd64.deb
> + read file
> + cp -s /home/ubuntu/google-chrome//home/ubuntu/google-chrome/google-chrome-stable_current_amd64.deb .
> cp: cannot stat '/home/ubuntu/google-chrome//home/ubuntu/google-chrome/google-chrome-stable_current_amd64.deb': No such file or _directory

[probonopd]

It works for me on Xubuntu 18.04.4 LTS using an older pkg2appimage. Maybe one of the latest commits has broken it. Can you go back and try older commits, and tell me which one is the newest that still works?

E.g., this one
https://raw.githubusercontent.com/AppImage/pkg2appimage/dc1dd8a522c6d913b3d3f7cd025a4adf2fa4295e/pkg2appimage

[child]

I'm not the original reporter, but I had exactly the same problem and can confirm it works with the older commit you suggested

[dmsoler]

Same problem here building recipe intef-exe: duplicated path in variable FILES.
I confirm it works with the commit you suggested.

[probonopd]

@sudo-give-me-coffee do you have any idea what might be causing this?

I am running into the same issue with this recipe:

app: BlueGriffon

ingredients:
  dist: xenial
  sources:
    - deb http://us.archive.ubuntu.com/ubuntu/ xenial main universe
  script:
    - VERSION=$(wget -c "http://bluegriffon.org/freshmeat/?C=M;O=D" -O - | grep href | head -n 2 | tail -n 1 | cut -d '"' -f 2 | cut -d / -f 1)
    - FILE=$(wget "http://bluegriffon.org/freshmeat/$VERSION/" -O - | grep deb | head -n 1 | cut -d '"' -f 2)
    - URL="http://bluegriffon.org/freshmeat/$VERSION/$FILE"
    - wget -c "$URL"
    - echo "$VERSION" > VERSION

script:
  - wget -c "http://sources.disruptive-innovations.com/bluegriffon/branches/multichar/branding/mozicon128.png" -O bluegriffon.png
  - mkdir -p usr/share/icons/128x128/apps/
  - cp bluegriffon.png usr/share/icons/128x128/apps/
  - cat > bluegriffon.desktop <<EOF
  - [Desktop Entry]
  - Name=BlueGriffon
  - Type=Application
  - Comment=The next-generation Web Editor
  - Exec=bluegriffon
  - Icon=bluegriffon
  - Categories=Development;
  - EOF
  - mkdir -p usr/share/applications
  - cp bluegriffon.desktop usr/share/applications

(...)

me@host:~$ bash -ex Downloads/pkg2appimage BlueGriffon.yml 

Starting pkgProblemResolver with broken count: 0
Starting 2 pkgProblemResolver with broken count: 0
Done
+ FILES=/home/me/BlueGriffon//home/me/BlueGriffon/bluegriffon-3.1.Ubuntu18.04-x86_64.deb
+ '[' '!' -z /home/me/BlueGriffon//home/me/BlueGriffon/bluegriffon-3.1.Ubuntu18.04-x86_64.deb ']'
+ read file
+ echo /home/me/BlueGriffon//home/me/BlueGriffon/bluegriffon-3.1.Ubuntu18.04-x86_64.deb
+ cp -s /home/me/BlueGriffon//home/me/BlueGriffon/bluegriffon-3.1.Ubuntu18.04-x86_64.deb .
cp: cannot stat '/home/me/BlueGriffon//home/me/BlueGriffon/bluegriffon-3.1.Ubuntu18.04-x86_64.deb': No such file or directory

[dmsoler]

The culprit seems to be line 282 in pkg2appimage file:

```
FILES=$(apt-get --allow-unauthenticated -o Apt::Get::AllowUnauthenticated=true $OPTIONS -y install --print-uris $INSTALL | cut -d "'" -f 2 | grep -e "^file" | cut -d ':' -f 2) || true  
```

In my case, building recipe intef-exe, if after the fail I run this command in intef-exe subdirectory:

```
apt-get --allow-unauthenticated -o Apt::Get::AllowUnauthenticated=true -o Debug::NoLocking=1 -o APT::Cache-Limit=125829120 -o Dir::Etc::sourcelist=./sources.list -o Dir::State=./tmp -o Dir::Cache=./tmp -o Dir::State::status=./status -o Dir::Etc::sourceparts=- -o APT::Get::List-Cleanup=0 -o APT::Get::AllowUnauthenticated=1 -o Debug::pkgProblemResolver=true -o Debug::pkgDepCache::AutoInstall=true -o APT::Install-Recommends=0 -o APT::Install-Suggests=0 -y install --print-uris intef-exe | cut -d "'" -f 2 | grep -e "^file"
```

the last line of the output I get is the following:

```
file:/tmp/pkg2appimage/intef-exe//tmp/pkg2appimage/intef-exe/intef-exe_2.5_all.deb
```

So, it seems it is apt-get --print-uris who puts the duplicated path in the output.

If I try this hack in line 282 to eliminate the duplicated path:

```
FILES="/$(apt-get --allow-unauthenticated -o Apt::Get::AllowUnauthenticated=true $OPTIONS -y install --print-uris $INSTALL | cut -d "'" -f 2 | grep -e "^file" | cut -d ':' -f 2 | awk 'BEGIN { FS="//"; } { print $2; }' )" || true
```

I get another error:

```
+ FILES=/tmp/pkg2appimage/intef-exe/intef-exe_2.5_all.deb
+ '[' '!' -z /tmp/pkg2appimage/intef-exe/intef-exe_2.5_all.deb ']'
+ echo /tmp/pkg2appimage/intef-exe/intef-exe_2.5_all.deb
+ read file
+ cp -s /tmp/pkg2appimage/intef-exe/intef-exe_2.5_all.deb .
cp: '/tmp/pkg2appimage/intef-exe/intef-exe_2.5_all.deb' and './intef-exe_2.5_all.deb' are the same file
``` 

After that, commenting out lines 283-287 works in my case: no error about cp trying to create a wrong symbolic link and the AppImage is built as expected.

[probonopd]

Thanks @dmsoler. Do you know what we'd have to change to fix this in a generic way?

[dmsoler]

I don't know "in a generic way", because I don't know what the purpose of the FILES variable is. I can tell that commenting out lines 282-287 in pkg2appimage allows me to build an AppImage with ingredients from local (debs:) or downloaded (script:) debs, and from Debian repositories. But I don't know if other things get broken without those lines.

These lines 282-287 were added in these two commits:

• Check and skip empty local APT repositories
• Enable pkg2appimage to handle local APT repositories

[dmsoler]

This patch is working for me:

issue429.patch.zip

To apply, unzip it in pkg2appimage directory and apply with patch < issue429.patch.

The patch modifies lines 282-287 in two ways:

• It removes duplicated path in the output of apt-get --print-uris (using awk, you need awk in your system).
• It tests if file exists before creating symbolic link.

AFAIK, everything else is working as before.

[SwagDevOps]

This patch is working for me:

issue429.patch.zip

To apply, unzip it in pkg2appimage directory and apply with patch < issue429.patch.

I think, you SHOULD do a pull request…

[probonopd]

Seems fixed in master now. Please retry.

[probonopd]

wget -c https://github.com/$(wget -q https://github.com/AppImage/pkg2appimage/releases -O - | grep "pkg2appimage-.*-x86_64.AppImage" | head -n 1 | cut -d '"' -f 2)
chmod +x ./pkg2appimage-*.AppImage
./pkg2appimage-*-x86_64.AppImage Google_Chrome
./out/Google_Chrome-*-x86_64.AppImage

Works for me: