Add option for use system libappimage #188
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheAssassin
requested changes
Jan 12, 2022
lib/CMakeLists.txt
Outdated
| add_subdirectory(libappimage EXCLUDE_FROM_ALL) | ||
| endif() | ||
| endif() |
There was a problem hiding this comment.
Blank line removed at end of file for no apparent reason.
TheAssassin
reviewed
Jan 15, 2022
lib/CMakeLists.txt
Outdated
| add_subdirectory(libappimage EXCLUDE_FROM_ALL) | ||
| set(APPIMAGE_LIB libappimage_shared PARENT_SCOPE) | ||
| else() | ||
| find_library(APPIMAGE_LIB appimage) |
There was a problem hiding this comment.
You should be able to find libappimage using find_package, since it generates an exported targets config.
|
I agree about similar options for other external libraries, but I need only system libappimage at this moment. |
|
Fixed in 7593d5a. Just set |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.