Skip to content

Conversation

@probonopd
Copy link
Member

@probonopd probonopd commented Aug 10, 2024

Closes #64 and #66

Only merge after discussion.

If I remember correctly, this flag is not documented by design since we don't want users to use it if they just have a broken FUSE setup. Using this command line option results in a degraded user experience with longer application start times, wasteful temporary space usage, etc.

Normal users should just fix their FUSE setup instead.

If I also remember correctly, this was mainly introduced for Docker setups, because Docker has issues with FUSE (at least without special workarounds). But Docker users prefer the use of environment variables.

Alternatives:

  • Keep it undocumented
  • Remove it and only offer an environment variable

In any case, it should be noted that this is only a feature of this runtime, and other AppImage runtimes may or may not have similar options. So users MUST NOT assume that every AppImage supports this command line option.

@probonopd probonopd requested a review from TheAssassin August 10, 2024 05:44
@github-actions
Copy link

Build for testing:
artifacts
Use at your own risk.

@github-actions
Copy link

Build for testing:
artifacts
Use at your own risk.

@TheAssassin
Copy link
Member

I'm open to removing it, but we should then document the environment variable somewhere (and make it a mandatory feature of the spec perhaps). I don't mind having the parameter either, though, since after all it's not a lot of extra code.

@Samueru-sama
Copy link

I don't like the idea of removing the option, that will break a lot of workflows that use it.

@TheAssassin
Copy link
Member

Please consider documenting the environment variable APPIMAGE_EXTRACT_AND_RUN.

@github-actions
Copy link

github-actions bot commented Dec 8, 2024

Build for testing:
artifacts x86_64
artifacts i686
artifacts armhf
artifacts aarch64
Use at your own risk.

@TheAssassin TheAssassin merged commit 7ac76ec into main Dec 8, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

--appimage-extract-and-run is undocumented

4 participants