feat: deserialization for entities used in collab stream #682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khorshuheng
requested review from
Horusiath and
appflowy
and removed request for
Horusiath
khorshuheng
changed the title
khorshuheng
force-pushed
the
collab-stream-entity-deser
branch
from
703af3c to
09ebdd0
Compare
khorshuheng
force-pushed
the
collab-stream-entity-deser
branch
from
09ebdd0 to
33e04bb
Compare
khorshuheng
changed the title
lilpoozie2005
approved these changes
Sep 4, 2024
lilpoozie2005
approved these changes
Sep 4, 2024
uxodb
pushed a commit
to uxodb/AppFlowy-Cloud
that referenced
this pull request
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is dependent on a AppFlowy-Collab patch version based upon AppFlowy-IO/AppFlowy-Collab#226 , which has not be merged. Once merge the dependency will be updated accordingly.
Support for deserializing encoded entities using protobuf with bincode as fallback has been introduced in the collab stream entities that needs to be shared via Redis stream/pubsub. Serialization will remain in bincode format and introduced in a future release.