feat: support uploading file with multiple part #625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
appflowy
commented
Jun 15, 2024
•
appflowy
commented
- Support multipart upload functionality and update the client API accordingly.
- Remove all objects for a given workspace when that workspace is deleted. Previously, the old approach removed blob metadata and S3 objects one by one. Now, simply remove the specific directory corresponding to the workspace ID.
- Replace the s3-rust crate with the aws-sdk-s3 crate, as s3-rust does not support multipart upload.
- Add more tests
speed2exe
reviewed
Jun 16, 2024
speed2exe
reviewed
Jun 16, 2024
lilpoozie2005
approved these changes
Sep 4, 2024
lilpoozie2005
approved these changes
Sep 4, 2024
lilpoozie2005
approved these changes
Sep 4, 2024
lilpoozie2005
approved these changes
Sep 4, 2024
lilpoozie2005
approved these changes
Sep 4, 2024
lilpoozie2005
approved these changes
Sep 4, 2024
uxodb
pushed a commit
to uxodb/AppFlowy-Cloud
that referenced
this pull request
Nov 13, 2024
* refactor: replace crate * chore: remove s3-rust crate * chore: test multiple upload * chore: client api * chore: client api * chore: v1 version upload,download * chore: fix test * chore: fix test * chore: remove workspace test * chore: fix wasm build * chore: update path * chore: update path * chore: rename * chore: expose file entity * chore: introduce client-api-entity * chore: fix build * chore: new url * chore: fix test * chore: merge main * chore: fix clippy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.