fix(deploy): add runtime admin authentication fallback - #1637
Draft
tonicofonico wants to merge 2 commits into
Draft
fix(deploy): add runtime admin authentication fallback#1637tonicofonico wants to merge 2 commits into
tonicofonico wants to merge 2 commits into
Conversation
…rontend docker-compose
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR adds a configurable NEXT_PUBLIC_DISABLE_SERVER_ACTIONS environment variable to the admin_frontend Docker Compose deployment and documents it in the deploy.env template to support disabling Next.js Server Actions in certain reverse-proxy setups. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
This was referenced Aug 1, 2026
Open
appflowy
marked this pull request as draft
August 4, 2026 09:14
Contributor
|
Maintainer follow-up: I pushed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add a Docker-runtime option for using browser-side authentication instead of the Admin frontend's authentication Server Actions:
The option is documented in
deploy.envand passed toadmin_frontendby Docker Compose. It remains disabled by default.Problem
Behind some TLS-terminating reverse proxies, Server Action requests can lose the expected cookie or origin context and cause an authentication redirect loop.
The original version of this PR used
NEXT_PUBLIC_DISABLE_SERVER_ACTIONS. That name is a build-time Next.js setting, so setting it when starting the prebuilt Admin image does not update the browser bundle.Runtime behavior
This PR is paired with AppFlowy-Admin #67, which injects
APPFLOWY_ADMIN_DISABLE_SERVER_ACTIONSintowindow.__APP_CONFIG__:false: continue using authentication Server Actionstrue: use the existing browser-side authentication API fallbackThis setting only changes Admin authentication behavior; it does not globally disable Next.js Server Actions.
Dependency
AppFlowy-Admin #67 must be merged and a compatible
appflowyinc/admin_frontendimage must be published before this PR is ready to merge.Verification
docker compose --env-file deploy.env config --quietfalseand an explicit override astrueAPPFLOWY_ADMIN_DISABLE_SERVER_ACTIONS=true/console/loginexposes the runtime value to browser code