chore: add metrics to redis collab stream #1116
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR comes with 2 changes:
CollabStreamMetrics
type which allows us to track how many streams are we scheduling to be read at given time:collab_stream_reads_enqueued
is incremented for every stream that has been observed. When the Redis xread returns and stream needs to be rescheduled for the next poll iteration, it also becomes enqueued.collab_stream_reads_dequeued
is incremented for every stream that scheduler returned for xread. These two metrics should be fairly close to each other. If they reads_enqueued grows faster than reads_dequeued it means, that we schedule new stream read requests faster than we can handle them.