-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ResilienceProperties to correctly handle null values #2300
Update ResilienceProperties to correctly handle null values #2300
Conversation
Adds logic handling a case when the value being requested is null
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2300 +/- ##
=======================================
Coverage ? 85.39%
=======================================
Files ? 313
Lines ? 7461
Branches ? 1126
=======================================
Hits ? 6371
Misses ? 745
Partials ? 345
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
@iliar-turdushev Are you planning on any other Polly PRs for any work you're doing on the resilience libraries anytime soon? If not, I'll cut an 8.4.2 release. |
No, I'm not. Perfect. I was about to ask when Polly 8.4.2 would be released. Thank you. |
There's an issue with our package signing I need to fix - once that's sorted I'll try to publish 8.4.2 again. |
Thanks for your contribution @iliar-turdushev - the changes from this pull request have been published as part of version 8.4.2 📦, which is now available from NuGet.org 🚀 |
The PR adds logic to handling cases when the value being requested from
ResilienceProperties
is null.Fixes #2299