Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ResilienceProperties to correctly handle null values #2300

Merged

Conversation

iliar-turdushev
Copy link
Contributor

The PR adds logic to handling cases when the value being requested from ResilienceProperties is null.

Fixes #2299

Adds logic handling a case when the value being requested is null
Copy link

codecov bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@1c6f3aa). Learn more about missing BASE report.
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2300   +/-   ##
=======================================
  Coverage        ?   85.39%           
=======================================
  Files           ?      313           
  Lines           ?     7461           
  Branches        ?     1126           
=======================================
  Hits            ?     6371           
  Misses          ?      745           
  Partials        ?      345           
Flag Coverage Δ
linux 85.39% <100.00%> (?)
macos 85.39% <100.00%> (?)
windows 85.39% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martincostello martincostello added this to the v8.4.2 milestone Sep 26, 2024
Copy link

@RussKie RussKie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@martincostello martincostello merged commit f7dc35f into App-vNext:main Sep 26, 2024
18 checks passed
@martincostello
Copy link
Member

@iliar-turdushev Are you planning on any other Polly PRs for any work you're doing on the resilience libraries anytime soon? If not, I'll cut an 8.4.2 release.

@iliar-turdushev
Copy link
Contributor Author

@iliar-turdushev Are you planning on any other Polly PRs for any work you're doing on the resilience libraries anytime soon? If not, I'll cut an 8.4.2 release.

No, I'm not. Perfect. I was about to ask when Polly 8.4.2 would be released. Thank you.

@martincostello
Copy link
Member

There's an issue with our package signing I need to fix - once that's sorted I'll try to publish 8.4.2 again.

Copy link
Contributor

Thanks for your contribution @iliar-turdushev - the changes from this pull request have been published as part of version 8.4.2 📦, which is now available from NuGet.org 🚀

@iliar-turdushev iliar-turdushev deleted the iliarturdu/fix-res-props branch September 27, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: ResilienceProperties works incorrectly when the value requested by a key is null
4 participants