Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce FaultGenerator and OutcomeGenerator<T> #1911

Merged
merged 3 commits into from
Jan 21, 2024

Conversation

martintmk
Copy link
Contributor

@martintmk martintmk commented Jan 20, 2024

Details on the issue fix or feature implementation

Contributes to #1901

Additionally, I have dropped OutcomeStrategyOptions as these are not used anywhere.

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

@martintmk martintmk added this to the v8.3.0 milestone Jan 20, 2024
Copy link

codecov bot commented Jan 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a1440fe) 84.65% compared to head (e8b3ff1) 84.79%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1911      +/-   ##
==========================================
+ Coverage   84.65%   84.79%   +0.14%     
==========================================
  Files         309      312       +3     
  Lines        6828     6893      +65     
  Branches     1050     1056       +6     
==========================================
+ Hits         5780     5845      +65     
  Misses        839      839              
  Partials      209      209              
Flag Coverage Δ
linux 84.79% <100.00%> (+0.14%) ⬆️
macos 84.79% <100.00%> (+0.14%) ⬆️
windows ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/Polly.Core/Simmy/Outcomes/OutcomeGenerator.cs Outdated Show resolved Hide resolved
src/Polly.Core/Simmy/Outcomes/OutcomeStrategyOptions.cs Outdated Show resolved Hide resolved
src/Polly.Core/Utils/RandomUtil.cs Outdated Show resolved Hide resolved
src/Polly.Core/Simmy/Utils/GeneratorHelper.cs Outdated Show resolved Hide resolved
@martintmk martintmk enabled auto-merge (squash) January 21, 2024 19:37
@martintmk martintmk merged commit cf00835 into main Jan 21, 2024
14 checks passed
@martintmk martintmk deleted the mtomka/simmy-api-cleanup branch January 21, 2024 20:09
peter-csala pushed a commit to peter-csala/Polly that referenced this pull request Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants