Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decrease the minimum allowed timeout #1888

Merged
merged 1 commit into from
Jan 10, 2024
Merged

Conversation

martintmk
Copy link
Contributor

@martintmk martintmk commented Jan 10, 2024

Pull Request

The issue or feature being addressed

Closes #1884

Details on the issue fix or feature implementation

Relaxing the min allowed timeout to 10ms. (from 1 second)

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

@martintmk martintmk added this to the v8.3.0 milestone Jan 10, 2024
Copy link

codecov bot commented Jan 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (28fba68) 84.66% compared to head (9e666a1) 84.66%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1888   +/-   ##
=======================================
  Coverage   84.66%   84.66%           
=======================================
  Files         309      309           
  Lines        6836     6836           
  Branches     1052     1052           
=======================================
  Hits         5788     5788           
  Misses        839      839           
  Partials      209      209           
Flag Coverage Δ
linux 84.66% <ø> (ø)
macos 84.66% <ø> (ø)
windows ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martintmk martintmk enabled auto-merge (squash) January 10, 2024 19:19
@martintmk martintmk merged commit 48f64d3 into main Jan 10, 2024
14 checks passed
@martintmk martintmk deleted the mtomka/decrease-min-timeout branch January 10, 2024 19:30
@silkfire
Copy link

silkfire commented Feb 9, 2024

@martintmk I noticed that the documentation of the property wasn't updated in this PR, it still states that the minimum is (above) 1 second.

On another note, is there a reason why the maximum value is 24 hours?

@martincostello
Copy link
Member

When we picked an upper limit, a day seemed a reasonable upper limit considering that is effectively millennia to a computer.

Having a thread trying to perform a single operation through Polly for up to an entire day seems on the extreme end for a thing for code to try and do, and we need to draw a line somewhere.

Do you have a use case where you need a single method invocation to run for more than 24 hours, but still need to eventually timeout?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature request]: Relax validation of TimeoutStrategyOptions.Timeout
3 participants