Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not record null dimensions #1423

Closed
wants to merge 1 commit into from

Conversation

martintmk
Copy link
Contributor

Details on the issue fix or feature implementation

Just investigating whether this is viable approach. It saves some CPU cycles and bandwidth in case the consumer does not care about individual dimensions.

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

@martintmk martintmk added the v8 Issues related to the new version 8 of the Polly library. label Jul 21, 2023
@martintmk martintmk added this to the v8.0.0 milestone Jul 21, 2023
@martintmk martintmk requested a review from geeknoid July 21, 2023 13:28
@martintmk
Copy link
Contributor Author

@geeknoid Wondering what's the recommended approach? Is this change ok?

@martintmk martintmk closed this Jul 26, 2023
@martincostello martincostello deleted the mtomka/do=not-report-empty-dimensions branch July 26, 2023 15:00
@geeknoid
Copy link
Contributor

Yep, seems fine to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v8 Issues related to the new version 8 of the Polly library.
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants