Make "Polly" unsigned by default and migrate signed to "Polly-Signed"

[ghuntley]

Hi Michael,

I'd like to propose to introduce a breaking change where by Polly is not
strong named by default. i.e. increment the semver major.

The migration path for existing users who are using strong-names would to be to
migrate to a separate nuget package. i.e.

Signed versions of the client libraries are also available at:

    PM> Install-Package Polly-Signed

This is the path that other OSS packages are taking:

• https://www.nuget.org/packages/Machine.Specifications-Signed/
• https://www.nuget.org/packages/FluentValidation-Signed/
• https://www.nuget.org/packages/ServiceStack.Text.Signed/

etc.

Important note Binding Redirect is not available w/clients that consume Portable Class Libraries:

• https://stackoverflow.com/questions/12337378/is-bindingredirect-supported-in-silverlight-windows-phone-and-metro
• https://wpdev.uservoice.com/forums/110705-app-platform/suggestions/2511980-assembly-binding-redirection-support

Suplemental material:

• https://nuget.codeplex.com/discussions/247827
• https://stackoverflow.com/questions/11656520/signing-binaries-of-open-source-projects
• http://haacked.com/archive/2012/02/16/changing-a-strong-name-is-a-major-breaking-change.aspx/
• Nuget dependency to Newtonsoft.Json miss the version restsharp/RestSharp#187
• https://json.codeplex.com/workitem/21995

Thoughts?
Geoff

[michael-wolfenden]

Geoff,

I am happy to go ahead with this change.

My preference is for unsigned assemblies but at the time there were no
clear nuget standards on naming the signed / unsigned packages, so I went
for the lesser evil and strongly named the library.

Michael
On 12/03/2014 7:17 AM, "Geoffrey Huntley" notifications@github.com wrote:

Hi Michael,

I'd like to propose to introduce a breaking change where by Polly is not
strong named by default. i.e. increment the semver major.

The migration path for existing users who are using strong-names would to
be to
migrate to a separate nuget package. i.e.

Signed versions of the client libraries are also available at:

PM> Install-Package Polly-Signed

This is the path that other OSS packages are taking:

• https://www.nuget.org/packages/Machine.Specifications-Signed/
• https://www.nuget.org/packages/FluentValidation-Signed/
• https://www.nuget.org/packages/ServiceStack.Text.Signed/

etc.

Important note binding Redirect is not available w/Portable Class
Libraries:

https://stackoverflow.com/questions/12337378/is-bindingredirect-supported-in-silverlight-windows-phone-and-metro

https://wpdev.uservoice.com/forums/110705-app-platform/suggestions/2511980-assembly-binding-redirection-support

Suplemental material:

• https://nuget.codeplex.com/discussions/247827

  https://stackoverflow.com/questions/11656520/signing-binaries-of-open-source-projects

  http://haacked.com/archive/2012/02/16/changing-a-strong-name-is-a-major-breaking-change.aspx/
• Nuget dependency to Newtonsoft.Json miss the version restsharp/RestSharp#187Nuget dependency to Newtonsoft.Json miss the version restsharp/RestSharp#187
• https://json.codeplex.com/workitem/21995

Thoughts,
Geoff

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/5
.