Skip to content

Conversation

@jb-cc
Copy link
Contributor

@jb-cc jb-cc commented Jun 20, 2025

No description provided.

Copilot AI review requested due to automatic review settings June 20, 2025 18:36
@jb-cc jb-cc changed the base branch from main to dev June 20, 2025 18:37
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances request counting functionality on the backend by generalizing “pending” counts to counts filtered by any request state, and upgrades the frontend with profile‐completion progress indicators and an admin search UI.

  • Backend:
    • Renames and extends countPendingRequestsForUsercountRequestsForUser to accept a RequestState filter.
    • Updates controller routes, DTOs, entities, tests, and OpenAPI spec accordingly.
  • Frontend:
    • Adds a reusable Progress component and injects profile‐completion logic into student/supervisor dashboards.
    • Implements an admin search page with debounce and filtering.
    • Introduces new admin pages (add‐admin, reset user, new‐cycle) and updates drawer/navigation.

Reviewed Changes

Copilot reviewed 31 out of 32 changed files in this pull request and generated no comments.

Show a summary per file
File Description
backend/src/modules/requests/supervision/supervision-requests.service.ts Generalize pending count to state‐based count
backend/src/modules/requests/supervision/count-query.dto.ts Add query DTO for request state
backend/src/modules/requests/supervision/entities/supervision-request-count.entity.ts Create new count entity with request_count field
backend/src/modules/requests/supervision/supervision-requests.controller.ts Update route, param, and returns to use state‐filtered count
Frontend/pages/supervisor/dashboard.vue Inject profile‐completion progress logic
Frontend/pages/student/dashboard.vue Inject profile‐completion progress logic
Frontend/pages/admin/add-admin.vue Add form and confirmation modal for creating new admins
Frontend/components/inputField/InputField.vue Add required prop handling to InputField component
Files not reviewed (1)
  • Frontend/package-lock.json: Language not supported
Comments suppressed due to low confidence (4)

Frontend/components/inputField/InputField.vue:85

  • The template uses required directly, but it’s not defined in the template scope. You need to reference props.required or destructure it from props to mark the label with an asterisk when the field is required.
      {{ label + (required ? '*' : '') }}

Frontend/pages/supervisor/dashboard.vue:70

  • The variable getProgress is declared with type number but assigned a function. Change this to a function type, e.g. const getProgress = (): number => { … }, to satisfy TypeScript.
const getProgress: number = () => {

Frontend/pages/student/dashboard.vue:226

  • Similar to the supervisor dashboard, getProgress is typed as a number but implemented as a function. Update its signature to (): number to avoid a type mismatch.
const getProgress: number = () => {

Frontend/pages/admin/add-admin.vue:79

  • The helper nextTick is used here but not imported from Vue. Add import { nextTick } from 'vue' at the top of the script block.
  await nextTick();

@jb-cc jb-cc merged commit eec92e4 into dev Jun 20, 2025
2 checks passed
@jb-cc jb-cc deleted the SCRUM-313-Frontend-Create-Progress-thing-and-add-Search-for-Admin branch June 20, 2025 19:04
jb-cc added a commit that referenced this pull request Jun 20, 2025
…-313) (#206)

Co-authored-by: FelixTeutsch <felix@teutsch.it>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants