Skip to content

Conversation

@LionRise
Copy link
Contributor

@LionRise LionRise commented Jun 13, 2025

  • added translation for pending request
  • added translation for matching swipe right request modal headline
  • improved request supervisor modal text (SCRUM 253)
  • added text to swiping to make it more clear and improve ux
  • delete data gives a (fake) toast that data is deleted
  • add error messages to supervisor manual adding (SCRUM 221)
  • fix wording in supervisor dashboard (SCRUM 276 )

@bernhaaard
Copy link
Contributor

bugbot run

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Modal Translation and Button Text Issues

The "Not Existing Student Modal" (modalNotExistingStudentRef) has two issues: its confirm-text prop is incorrectly set to an empty string, resulting in a blank button. Additionally, its sub-text prop uses the translation key for existing students. Both props should use the appropriate addNewStudent translation keys for consistency and proper display.

Frontend/components/SupervisorStudentList/SupervisorStudentList.vue#L270-L276

:checkbox-label="t('settings.supervisorStudentList.checkboxLabel')"
confirm-text=""
icon="user-group"
image-alt="Logo"
image-src="../images/Superwise_Logo.svg"
setting-key="showAddStudentModal"
:sub-text="t('settings.supervisorStudentList.addExistingStudent.subText')"

Fix in Cursor


BugBot free trial expires on June 24, 2025
You have used $0.00 of your $25.00 spend limit so far. Manage your spend limit in the Cursor dashboard.

Was this report helpful? Give feedback by reacting with 👍 or 👎

@LionRise LionRise force-pushed the SCRUM-299-Frontend-Minor-UI-UX-fixes branch from 9bcabb7 to 8823cde Compare June 17, 2025 18:35
@LionRise LionRise marked this pull request as ready for review June 17, 2025 18:38
@LionRise LionRise requested a review from jb-cc as a code owner June 17, 2025 18:38
@jb-cc jb-cc force-pushed the dev branch 2 times, most recently from 9774d44 to 8cd0044 Compare June 18, 2025 01:02
LionRise added 3 commits June 18, 2025 03:29
…or matching swipe right request modal headline, added text to swiping to make it more clear and improve ux, delete data gives a (fake) toast that data is deleted
@jb-cc jb-cc force-pushed the SCRUM-299-Frontend-Minor-UI-UX-fixes branch from 8823cde to e238e06 Compare June 18, 2025 01:29
@jb-cc
Copy link
Contributor

jb-cc commented Jun 18, 2025

When I let go of the swipe, the text still gets shown. Please switch out the text for an icon like in the figma design, and fix the text being shown
image

Copy link
Contributor

@jb-cc jb-cc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls take a look at my previous comment, and also call the delete api entpoint on deletion and log the user out

@jb-cc jb-cc requested a review from Copilot June 18, 2025 23:09
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces minor UI/UX improvements across multiple supervisor and student pages by adding toast notifications, refining translation usage, and enhancing swipe interactions.

  • Added toast notification logic and <Toast> components for data deletion and supervisor/student actions
  • Updated i18n locale files with new translation keys and adjusted existing texts
  • Extended the swipe container to show directional text overlays and accept localized swipe labels

Reviewed Changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.

Show a summary per file
File Description
Frontend/pages/supervisor/data-protection.vue Added toastData state, delete confirmation toast, and <Toast>
Frontend/pages/supervisor/currently-supervising.vue Wrapped student add in try/catch, added success/error toasts
Frontend/pages/student/requests.vue Reformatted imports/props, updated modal string interpolations
Frontend/pages/student/matching.vue Added localized swipe-left/right texts and updated modal content
Frontend/pages/student/data-protection.vue Mirrored supervisor data-protection toast additions
Frontend/pages/admin/data-protection.vue Mirrored data-protection toast additions
Frontend/i18n/locales/en-GB.json Added dataDeleted, error, success, and swipe-related keys
Frontend/i18n/locales/de-DE.json Same as en-GB for German locale
Frontend/components/SwipeContainer/SwipeContainer.vue Introduced swipeLeftText/swipeRightText props and overlay UI
Frontend/components/SupervisorStudentList/...vue Updated translation key paths for confirmation modals
Comments suppressed due to low confidence (9)

Frontend/pages/supervisor/data-protection.vue:23

  • The ref function is used here but ref is not imported from 'vue', causing a runtime error. Add import { ref } from 'vue' at the top of the script.
const toastData = ref({

Frontend/pages/supervisor/data-protection.vue:75

  • The <Toast> component is used in the template but is not imported in the script setup, leading to an undefined component at runtime. Add import Toast from '~/components/Toast.vue' (or the correct path).
    <Toast

Frontend/pages/student/data-protection.vue:22

  • The ref function is used here but ref is not imported from 'vue', causing a runtime error. Add import { ref } from 'vue' at the top.
const toastData = ref({

Frontend/pages/student/data-protection.vue:74

  • The <Toast> component is used in the template but is not imported, leading to an undefined component. Add the appropriate import for Toast.
    <Toast

Frontend/pages/admin/data-protection.vue:25

  • The ref function is used here but ref is not imported from 'vue', causing a runtime error. Add import { ref } from 'vue' at the top.
const toastData = ref({

Frontend/pages/admin/data-protection.vue:77

  • The <Toast> component is used in the template but is not imported in the script setup. Add an import for Toast to avoid component resolution errors.
    <Toast

Frontend/components/SupervisorStudentList/SupervisorStudentList.vue:228

  • This translation key path (settings.supervisorStudentList.removeStudent.confirmText) does not exist in the locales. Either update the JSON to include it or revert to the correct key (supervisorStudentList.removeStudent.confirmText).
      "

Frontend/components/SupervisorStudentList/SupervisorStudentList.vue:257

  • This translation key path (settings.supervisorStudentList.addExistingStudent.confirmText) is not defined in the locale files. Adjust the key or add it to the JSON to prevent missing text.
      "

Frontend/components/SupervisorStudentList/SupervisorStudentList.vue:278

  • This translation key (settings.supervisorStudentList.addNotExistingStudent.confirmText) is not present in the locales. Either correct the path to match existing keys or add the missing entries.
      "

@Mohammed87FS Mohammed87FS force-pushed the dev branch 2 times, most recently from 373ee7d to 8cd0044 Compare June 19, 2025 09:42
@LionRise LionRise requested a review from jb-cc June 19, 2025 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants