Parameter validation: Raises error for all missing #886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidwessman
commented
Jun 8, 2023
| @@ -24,6 +24,20 @@ def initialize(param) | |||
| end | |||
| end | |||
|
|
|||
| class ParamMultipleMissing < ParamError | |||
There was a problem hiding this comment.
Would be nice to inherit from the same error as ParamMissing, but we do not have the defined param here.
- Instead of just raising `ParamMissing` for the first missing, instead raise a compound `ParamMultipleMissing` if there are more than one missing. - Adds specs for both POST and GET requests. - Fixes Apipie#802
davidwessman
force-pushed
the
802-report-all-missing-parameters
branch
from
758bd7c
to
2b44883
Compare
|
I have no good way to solve the last rubocop warnings, do you usually add ignores if the complexity grows? Not sure if I can split it up more since it is meta-programming |
|
Running |
mathieujobin
approved these changes
Jun 9, 2023
There was a problem hiding this comment.
Yep, its OK to ignore ModuleLength and BlockLength rubocop offenses, you can use the comment as @PanosCodes suggested. and I will merge.
Thank you
mathieujobin
approved these changes
Jun 9, 2023
|
Thanks! 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ParamMissingfor the first missing,instead raise a compound
ParamMultipleMissingif there are morethan one missing.