ruby 3.0: fixes the dreaded 'wrong number of arguments (given 1, expected 0)' error. #725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…1 + being less explicit. Using just super and not super() fixes the dreaded
' wrong number of arguments (given 1, expected 0)
# ./vendor/bundle/ruby/3.0.0/gems/apipie-rails-0.5.19/lib/apipie/extractor/recorder.rb:153:in `process'
# ./vendor/bundle/ruby/3.0.0/gems/rails-controller-testing-1.0.5/lib/rails/controller/testing/template_assertions.rb:62:in `process'
'
error.
see here:
https://stackoverflow.com/questions/31816149/difference-between-calling-super-and-calling-super
ofedoren
reviewed
Aug 9, 2021
| @@ -150,8 +150,8 @@ def analyze(env, &block) | |||
| end | |||
|
|
|||
| module FunctionalTestRecording | |||
| def process(*args) # action, parameters = nil, session = nil, flash = nil, http_method = 'GET') | |||
| ret = super(*args) | |||
| def process(*, **) # action, parameters = nil, session = nil, flash = nil, http_method = 'GET') | |||
There was a problem hiding this comment.
Isn't it better to use
def process(*args, **kargs)
ret = super
# ...
end?
There was a problem hiding this comment.
You can. I see both in the rails core. I mean, I literally read the rails source and copied the signature from there, but I don't actually have a strong opinion one way or the other.
There was a problem hiding this comment.
If it would make you accept the PR, I'll change it ...
ofedoren
approved these changes
Aug 10, 2021
| @@ -150,8 +150,8 @@ def analyze(env, &block) | |||
| end | |||
|
|
|||
| module FunctionalTestRecording | |||
| def process(*args) # action, parameters = nil, session = nil, flash = nil, http_method = 'GET') | |||
| ret = super(*args) | |||
| def process(*, **) # action, parameters = nil, session = nil, flash = nil, http_method = 'GET') | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
by being less explicit in the super call, ie using just super and not super().
Also, line up the parameter signature with rails 6.0+.
In particular this stack track:
see here for details, if you care.
https://stackoverflow.com/questions/31816149/difference-between-calling-super-and-calling-super