Load file directly instead of using Rails constant loading to do so #665
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @speckins for looking into this: mind rebasing: I've just updated the travis matrix and some unrelated fixes that caused the tests to fail |
speckins
force-pushed
the
load-files-instead-of-constants
branch
from
c3b2f0c to
56517cc
Compare
- Since Rails constant loading looks in Rails eager_load and autoload paths, it's possible for files outside of api_controllers_matcher to be loaded. - Files that do not define an expected constant will cause a NameError to be raised. This was most commonly encountered with files in the concerns/ directory, which caused a NameError for a missing "Concerns::<name>" constant. This makes use of ActiveSupport::Dependencies::Loadable#require_dependency to explicitly load the file and its constants in a way that cooperates with Rails constant loading and unloading. https://guides.rubyonrails.org/autoloading_and_reloading_constants.html#require-dependency https://api.rubyonrails.org/classes/ActiveSupport/Dependencies/Loadable.html#method-i-require_dependency Fixes Apipie#347.
|
@iNecas Rebased. |
iNecas
approved these changes
May 22, 2019
|
apipie-0.5.16 released to rubygems. Thanks @speckins |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for files outside of api_controllers_matcher to be loaded
to be raised. This was most commonly encountered with files in the
concerns/ directory, which caused a NameError for a missing
"Concerns::" constant.
This make use of ActiveSupport::Dependencies::Loadable#require_dependency
to explicitly load the file and its constants in a way that cooperates
with Rails constant loading and unloading.
https://guides.rubyonrails.org/autoloading_and_reloading_constants.html#require-dependency
https://api.rubyonrails.org/classes/ActiveSupport/Dependencies/Loadable.html#method-i-require_dependency
Fixes #347.