Skip to content

constantize controller class before calling superclass #558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 8, 2017

Conversation

ydkn
Copy link
Contributor

@ydkn ydkn commented Sep 8, 2017

The commit 69c5bdc introduced calling superclass on strings due to the fact that @controller_versions is now holding only the controller name as a string instead of the controller class itself. Due to this situation the 0.5.3 release is broken for me.

/Users/fl/.rvm/gems/ruby-2.4.1/gems/apipie-rails-0.5.3/lib/apipie/application.rb:129:in `controller_versions': undefined method `superclass' for "V1::ApplicationController":String (NoMethodError)
	from /Users/fl/.rvm/gems/ruby-2.4.1/gems/apipie-rails-0.5.3/lib/apipie/application.rb:388:in `version_prefix'
	from /Users/fl/.rvm/gems/ruby-2.4.1/gems/apipie-rails-0.5.3/lib/apipie/application.rb:346:in `get_resource_name'
	from /Users/fl/.rvm/gems/ruby-2.4.1/gems/apipie-rails-0.5.3/lib/apipie/application.rb:104:in `define_resource_description'
	from /Users/fl/.rvm/gems/ruby-2.4.1/gems/apipie-rails-0.5.3/lib/apipie/apipie_module.rb:18:in `method_missing'
	from /Users/fl/.rvm/gems/ruby-2.4.1/gems/apipie-rails-0.5.3/lib/apipie/dsl_definition.rb:145:in `block in resource_description'
	from /Users/fl/.rvm/gems/ruby-2.4.1/gems/apipie-rails-0.5.3/lib/apipie/dsl_definition.rb:144:in `map'
	from /Users/fl/.rvm/gems/ruby-2.4.1/gems/apipie-rails-0.5.3/lib/apipie/dsl_definition.rb:144:in `resource_description'
	from /Users/fl/XXX/app/controllers/v1/application_controller.rb:4:in `<class:ApplicationController>'

@iNecas
Copy link
Member

iNecas commented Sep 8, 2017

Ahh, sry about that, merging now, will do new release later today. Thanks @ydkn

@iNecas iNecas merged commit f5b7b26 into Apipie:master Sep 8, 2017
@iNecas
Copy link
Member

iNecas commented Sep 8, 2017

apipie-rails-0.5.4, including this fix, got just released. Thanks @ydkn for quick fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants