Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds allow_blank option #508

Merged
merged 2 commits into from
Dec 16, 2016
Merged

Adds allow_blank option #508

merged 2 commits into from
Dec 16, 2016

Conversation

MrLeebo
Copy link
Contributor

@MrLeebo MrLeebo commented Dec 15, 2016

Based on @Pajk 's comments in the outcome of #403, this is a PR to introduce the allow_blank: true parameter option.

Like allow_nil, but for blank values. false, "", ' ', nil, [], and {} are all blank.

Usage:

param :age, :number, allow_blank: true

@MrLeebo
Copy link
Contributor Author

MrLeebo commented Dec 15, 2016

Tests pass on my local machine and the Travis CI error doesn't look like it is related to this. Should I be concerned about that?

@mtparet mtparet self-requested a review December 16, 2016 10:02
@mtparet mtparet merged commit 150c982 into Apipie:master Dec 16, 2016
@mtparet
Copy link
Contributor

mtparet commented Dec 16, 2016

Thanks!

@mtparet mtparet added this to the v0.3.8 milestone Dec 16, 2016
@iNecas
Copy link
Member

iNecas commented Feb 18, 2017

apipie-rails-0.4.0 has just been released, including this enhancement. Thanks @MrLeebo for help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants