Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: Apipie/apipie-rails
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.9.3
Choose a base ref
...
head repository: Apipie/apipie-rails
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.9.4
Choose a head ref
  • 13 commits
  • 37 files changed
  • 4 contributors

Commits on Mar 8, 2023

  1. Disables Style/IfUnlessModifier rule (#841)

    Having this rule enabled forces the modifier if statement to be used
    
    So this
    
    ```
    if Apipie.configuration.swagger_api_host.present?
      @Swagger[:host] = Apipie.configuration.swagger_api_host
    end
    ```
    
    should be changed to 
    
    `@swagger[:host] = Apipie.configuration.swagger_api_host if Apipie.configuration.swagger_api_host.present?`
    
    resulting in longer, harder to read lines.
    
    Since the use the regular if statement all over the gem's codebase we can
    disable this rule.
    PanosCodes authored Mar 8, 2023
    Configuration menu
    Copy the full SHA
    43428fc View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2023

  1. Layout/SpaceAroundMethodCallOperator-20230317233257 (#847)

    * 🚓 regenerate rubocop todo
    
    * 🚓 Layout/SpaceAroundMethodCallOperator
    
    * 🚓 regenerate rubocop todo
    
    ---------
    
    Co-authored-by: Rubocop Challenger <rubocop@payrollhero.com>
    github-actions[bot] and Rubocop Challenger authored Mar 20, 2023
    Configuration menu
    Copy the full SHA
    2fc6aca View commit details
    Browse the repository at this point in the history
  2. Disables FrozenStringLiteralComment rule (#840)

    * Disables FrozenStringLiteralComment rule
    
    Why https://github.com/testdouble/standard#why-arent-frozen_string_literal-true-magic-comments-enforced
    
    * Pass error message to constructor instead of overriding `#to_s`
    
    `Exception#to_s` returns the given message,
    we can pass the error message to constructor instead of overriding the method.
    
    This will also fix the Rubocop offenses.
    
    * Exclude files from MissingSuper
    PanosCodes authored Mar 20, 2023
    Configuration menu
    Copy the full SHA
    d5cd745 View commit details
    Browse the repository at this point in the history
  3. RSpec/EmptyLineAfterExample-20230301233314 (#834)

    * 🚓 regenerate rubocop todo
    
    * 🚓 RSpec/EmptyLineAfterExample
    
    * 🚓 regenerate rubocop todo
    
    ---------
    
    Co-authored-by: Rubocop Challenger <rubocop@payrollhero.com>
    Co-authored-by: Mathieu Jobin <99191+mathieujobin@users.noreply.github.com>
    3 people authored Mar 20, 2023
    Configuration menu
    Copy the full SHA
    2e37a03 View commit details
    Browse the repository at this point in the history
  4. Layout/SpaceAroundEqualsInParameterDefault-20230315233256 (#846)

    * 🚓 regenerate rubocop todo
    
    * 🚓 Layout/SpaceAroundEqualsInParameterDefault
    
    * 🚓 regenerate rubocop todo
    
    ---------
    
    Co-authored-by: Rubocop Challenger <rubocop@payrollhero.com>
    Co-authored-by: Mathieu Jobin <99191+mathieujobin@users.noreply.github.com>
    3 people authored Mar 20, 2023
    Configuration menu
    Copy the full SHA
    e273d55 View commit details
    Browse the repository at this point in the history
  5. Rails/TimeZone-20230310233258 (#844)

    * 🚓 regenerate rubocop todo
    
    * 🚓 Rails/TimeZone
    
    * 🚓 regenerate rubocop todo
    
    ---------
    
    Co-authored-by: Rubocop Challenger <rubocop@payrollhero.com>
    Co-authored-by: Mathieu Jobin <99191+mathieujobin@users.noreply.github.com>
    3 people authored Mar 20, 2023
    Configuration menu
    Copy the full SHA
    92f115f View commit details
    Browse the repository at this point in the history

Commits on Mar 23, 2023

  1. Performance/StringInclude-20230322233257 (#850)

    * 🚓 regenerate rubocop todo
    
    * 🚓 Performance/StringInclude
    
    * 🚓 regenerate rubocop todo
    
    ---------
    
    Co-authored-by: Rubocop Challenger <rubocop@payrollhero.com>
    github-actions[bot] and Rubocop Challenger authored Mar 23, 2023
    Configuration menu
    Copy the full SHA
    a86ac97 View commit details
    Browse the repository at this point in the history
  2. Style/RegexpLiteral-20230320233251 (#849)

    * 🚓 regenerate rubocop todo
    
    * 🚓 Style/RegexpLiteral
    
    * 🚓 regenerate rubocop todo
    
    ---------
    
    Co-authored-by: Rubocop Challenger <rubocop@payrollhero.com>
    Co-authored-by: Mathieu Jobin <99191+mathieujobin@users.noreply.github.com>
    3 people authored Mar 23, 2023
    Configuration menu
    Copy the full SHA
    ce281e1 View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2023

  1. Configuration menu
    Copy the full SHA
    2bb7ca5 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    8f14191 View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2023

  1. Style/RedundantConstantBase-20230403233322 (#858)

    * 🚓 regenerate rubocop todo
    
    * 🚓 Style/RedundantConstantBase
    
    * 🚓 regenerate rubocop todo
    
    ---------
    
    Co-authored-by: Rubocop Challenger <rubocop@payrollhero.com>
    github-actions[bot] and Rubocop Challenger authored Apr 6, 2023
    Configuration menu
    Copy the full SHA
    5fc1bf5 View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2023

  1. Separate nested resource name (#855)

    * Fix namespaced resources seperator
    The expected behavior when `Apipie.configuration.namespaced_resources?` 
    is true is for a nested resource like `V1::Users::TweetsController` to
    return `v1-users-tweets` however it was returning `v1userstweets`
    
    * Refactor resource description spec
    
    * Update `ResourceDescription`'s `name` `resource_name` and id
    - Rename the `resource_name` argument to `id`, it can be missleading
    - Create `name` method return a human readable resource name depending 
      on the `@id`. Example if id is `some-nested-resource` `#name` will 
      return `Some::Nested::Resource`
    PanosCodes authored Apr 10, 2023
    Configuration menu
    Copy the full SHA
    1f28905 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9d8823e View commit details
    Browse the repository at this point in the history
Loading