Disables Style/IfUnlessModifier rule #841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having this rule enabled forces the modifier if statement to be used So this ``` if Apipie.configuration.swagger_api_host.present? @Swagger[:host] = Apipie.configuration.swagger_api_host end ``` should be changed to `@swagger[:host] = Apipie.configuration.swagger_api_host if Apipie.configuration.swagger_api_host.present?` resulting in longer, harder to read lines. Since the use the regular if statement all over the gem's codebase we can disable this rule.
|
Alright |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having this rule enabled forces the modifier if statement to be used
So this
should be changed to
resulting in longer, harder to read lines.
Since we use the regular if statement all over the gem's codebase we can disable this rule.