-
Notifications
You must be signed in to change notification settings - Fork 3
Fixes to get Aperture building on Linux #62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few comments
doc/building_linux.md
Outdated
- 64GB hard drive space | ||
- 4 or more core CPU (you could get by with 2 cores, but the process will take much longer) | ||
- GCC 11 compiler (which is the default version on Ubuntu 22.04 LTS) | ||
|
||
It is recommended that you use a virtual machine for compiling, ensuring the guest can meet the hardware requirements. | ||
If you are using a newer version of Linux, you may need to make sure you're still using gcc 11, as Aperture may not compile with newer versions of gcc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kernel: Linux 6.12.21-gentoo-x86_64
GCC Version: gcc (Gentoo 14.2.1_p20241221 p7) 14.2.1 20241221
Adding set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-error=nonnull -Wno-error=maybe-uninitialized")
to indra/cmake/00-Common.cmake
I was able to successfully compile
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
confirmed, works for me. Are we okay with disabling a compiler warning?
📝 Pull Request Description & Purpose
This PR contains fixes (including documentation) to get Aperture viewer building on (Ubuntu) Linux.
There are a bunch of minor adjustments needed, mainly around changing the "firestorm" name everywhere, and a couple of small code adjustments.
Where possible I've taken the (windows) defaults for settings as they seem to work for me.
I have not used the Windows build so can't compare performance/visuals, but it works well for me, performance is comparable to other viewers I use.
Known Issues
These are annoying, but I figured it's more important to get a version that works at all for people to test than spend ages fixing these.
🧪 Testing Done
I have built it using an Ubuntu 22.04 virtual machine, both with and without (optional) fmodstudio.
I have used it as my daily SL client over a few days, ten hours or so, just going to music streaming places, shopping, and taking photographs.
My PC is Intel based, with 64G RAM and an Nvidia RTX3080 graphics card. I use Ubuntu 24.04.
I have NOT tested that the resulting code still builds correctly on Windows or MacOS as I do not currently have access to those. I don't believe there's any change that would affect them. I have not tested voice.