-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
APERTA-10963 preprint doi in paper tracker requires flag #3410
Conversation
Notes to reviewer.
this is only possible in a |
</th> | ||
{{#if preprintsEnabled}} | ||
<th class="paper-tracker-paper-preprint-id-column"> | ||
{{sort-link text="Manuscript Preprint ID" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per AC 2 this should be "Pre-print DOI"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
crazy, I swear I did that. Must have stashed it or something. thanks
@amaxsurge I believe the test problem is due to the feature flag service not being stubbed out. See https://github.com/Tahi-project/tahi/blob/master/client/tests/integration/pods/components/admin-page/component-test.js#L19 for an example, but I can't get this to work directly with your test, probably because of some strange difference between qunit test types. |
becfc52
to
98f3b0b
Compare
@egh yeah I basically wrote that exact same code that you put in the example and could not get it to work. Let me keep reading and playing with it |
98f3b0b
to
6449d59
Compare
6449d59
to
87968d2
Compare
@egh all tests are passing here. Is this still in review? |
@@ -45,6 +45,7 @@ module('Integration: Paper Tracker', { | |||
Factory.resetFactoryIds(); | |||
App = startApp(); | |||
server = setupMockServer(); | |||
$.mockjax({url: '/api/feature_flags.json', status: 200, responseText: {PREPRINT: true}}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
JIRA issue: https://jira.plos.org/jira/browse/APERTA-10963
What this PR does:
At /paper_tracker the preprint doi column is now hidden unless the corresponding preprint flag is checked
Special instructions for Review or PO:
Toggle the flag checkbox, view the column
Code Review Tasks:
Author tasks (delete tasks that don't apply to your PR, this list should be finished before code review):
Reviewer tasks (these should be checked or somehow noted before passing on to PO):