Skip to content

Add topic to ContractEvent docs.#3586

Merged
reedsa merged 3 commits into
ApeWorX:mainfrom
reedsa:event-topic-docs
Jan 22, 2025
Merged

Add topic to ContractEvent docs.#3586
reedsa merged 3 commits into
ApeWorX:mainfrom
reedsa:event-topic-docs

Conversation

@reedsa
Copy link
Copy Markdown
Contributor

@reedsa reedsa commented Jan 22, 2025

What was wrong?

Closes #3556

How was it fixed?

ContractEvent docs now include the topic in the class attributes section.

Todo:

  • Clean up commit history
  • Add or update documentation related to these changes
  • Add entry to the release notes

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

reedsa pushed a commit to reedsa/web3.py that referenced this pull request Jan 22, 2025
@reedsa reedsa requested review from fselmo, kclowes and pacrob January 22, 2025 17:46
Comment thread docs/web3.contract.rst Outdated
Comment thread newsfragments/3586.docs.rst Outdated
Copy link
Copy Markdown
Collaborator

@fselmo fselmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Copy Markdown
Collaborator

@kclowes kclowes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! :shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improvements for *ContractEvent and *ContractFunction APIs

3 participants