Flaky test help#3583
Merged
Merged
Conversation
- We recently removed the specific flaky xfail markers from some replace transaction tests. They now sometimes fail with "nonce too low", which is better than the previous timeout issues. We should add the flaky_geth_dev_mining decorator to these so they can run again and ideally pass 1 out of 3 times. - We also sometimes get performance issues with older Python versions on the multiple contract init core tests. Let's keep this a more conservative number for now.
Collaborator
Author
|
Seems to be working well now with just the geth dev mining decorator (flaky w/ |
kclowes
approved these changes
Jan 17, 2025
Collaborator
kclowes
left a comment
kclowes
left a comment
There was a problem hiding this comment.
LGTM after a newsfragment gets added!
This was referenced Feb 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was wrong?
We recently removed the specific flaky xfail markers from some replace transaction tests. They now sometimes fail with "nonce too low", which is better than the previous timeout issues. We should add the flaky_geth_dev_mining decorator to these so they can run again and ideally pass 1 out of 3 times.
We also sometimes get performance issues with older Python versions on the multiple contract init core tests. Let's keep this a more conservative number for now.
1.5->1.75should do I think.Todo:
Cute Animal Picture
0_o