Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: removed dockerfile documentation and added readme documentation for dockerfile #10

Merged
merged 2 commits into from
Oct 24, 2023
Merged

docs: removed dockerfile documentation and added readme documentation for dockerfile #10

merged 2 commits into from
Oct 24, 2023

Conversation

sabotagebeats
Copy link
Contributor

@sabotagebeats sabotagebeats commented Oct 21, 2023 •
edited
Loading

fixes: #3
fixes: #2

sabotagebeats
sabotagebeats commented Oct 21, 2023
View reviewed changes
Copy link
Contributor Author

@sabotagebeats sabotagebeats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems fine to me, let me know if I should do additional changes to resolve #2 and #3

mikeshultz
mikeshultz approved these changes Oct 23, 2023
View reviewed changes
Copy link
Member

@mikeshultz mikeshultz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Ninjagod1251 Ninjagod1251 merged commit d51761e into main Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ninjagod1251 Ninjagod1251 Ninjagod1251 approved these changes

@mikeshultz mikeshultz mikeshultz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor: clean unused statements from dockerfile Docs: clean up documentational todos from docker file
3 participants
@sabotagebeats @mikeshultz @Ninjagod1251