This repository has been archived by the owner on Jun 6, 2024. It is now read-only.
generated from ApeWorX/project-template
-
-
Notifications
You must be signed in to change notification settings - Fork 12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antazoey
reviewed
Jan 26, 2023
@@ -66,7 +66,7 @@ | |||
"hexbytes", # Use same version as eth-ape | |||
"pydantic", # Use same version as eth-ape | |||
# ** ApeWorX maintained ** | |||
"eth-ape>=0.5.9,<0.6", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to take in all similar things to this PR: https://github.com/ApeWorX/ape-infura/pull/57/files
Like file by file, apply the changes here if it makes sense
antazoey
reviewed
Jan 26, 2023
antazoey
approved these changes
Jan 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work on this! I think it looks great.
We will see after we do the full release
APE-526 "chore: upgrade to 0.6" (ApeWorX/ape-starknet #128)
What I didfixes: # APE-507 How I did itHow to verify itChecklist
ApeWorX/ape-starknet #128 by @dtdang on GitHub via LinearSync |
antazoey
reviewed
Jan 30, 2023
antazoey
reviewed
Jan 30, 2023
antazoey
approved these changes
Feb 1, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
fixes: APE-526
How I did it
How to verify it
Checklist