Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: makes uninstall work when using the long name displayed in ape pm list #2287

Merged
merged 5 commits into from
Sep 17, 2024
Merged

fix: makes uninstall work when using the long name displayed in ape pm list #2287

merged 5 commits into from
Sep 17, 2024

Conversation

bitwise-constructs
Copy link
Contributor

@bitwise-constructs bitwise-constructs commented Sep 17, 2024 •
edited
Loading

What I did

Added a check and test for also checking the package_id of a dependency when uninstalling by name. package_id is the long name displayed in ape pm list

fixes: #2282
Fixes: APE-1816

How to verify it

run ape pm uninstall OpenZeppelin/openzeppelin-contracts on an OpenZeppelin dependency

Checklist

  • All changes are completed
  • New test cases have been added
  • Documentation has been updated

antazoey
antazoey previously approved these changes Sep 17, 2024
View reviewed changes
Copy link
Member

@antazoey antazoey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just update the userguide a bit and we are good to go

@bitwise-constructs bitwise-constructs merged commit 385e77c into ApeWorX:main Sep 17, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antazoey antazoey antazoey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Long-name not working with ape pm uninstall command
2 participants
@bitwise-constructs @antazoey