fix: if only single compiler error, avoid wrapping in a new error #2251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fubuloubu
previously approved these changes
Aug 27, 2024
| raise errors[0] | ||
|
|
||
| elif len(errors) > 1: | ||
| # Raise a combined error. | ||
| formatted_errors = [f"{e}" for e in errors] | ||
| error_message = "\n\n".join(formatted_errors) | ||
| raise CompilerError(error_message) |
There was a problem hiding this comment.
Wonder if python 3.11+ exception groups make sense to use when it becomes available to us
There was a problem hiding this comment.
Wow this is cool!
Idea: could try to work this in for the Python versions that support it and have it the dumb way now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Ape shows you all compiler errors across compilers.
That is great, except when there was only a single error, thus causing a pointless exception being thrown on the stack.
How I did it
if len(errors) is just 1, just raise that error instead.
How to verify it
Compile with 1 compiler failing - should just see the custom
Compile with 2 compilers failing - should see them amassed
I added tests for both of these cases.
Checklist