Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: issue where custom-networks defaulted to forked-providers when they were not forked networks. #2239

Conversation

antazoey
Copy link
Member

What I did

When using a provider that isn't node for a non-forked custom network would still use forked provider version.

How I did it

  • Notice both classes were registering
  • Add condition to make sure the correct class was registering

How to verify it

foundry:
  blast:
    mainnet-tenderly:
      uri: "https://[REDACTED]"

networks:
  custom:
     - name: mainnet-tenderly
       chain_id: 69420
       ecosystem: blast
       base_ecosystem_plugin: optimism
       default_provider: foundry

connect:

ape console --network blast:mainnet-tenderly:foundry

Checklist

  • All changes are completed
  • New test cases have been added
  • Documentation has been updated

@antazoey antazoey marked this pull request as draft August 23, 2024 14:57
@antazoey antazoey marked this pull request as ready for review August 23, 2024 15:17
@antazoey antazoey force-pushed the fix/forked-provider-added-to-non-forked-custom-network branch from e9227a4 to 686a819 Compare August 23, 2024 15:20
@antazoey antazoey force-pushed the fix/forked-provider-added-to-non-forked-custom-network branch from 686a819 to d9ed1b5 Compare August 23, 2024 15:20
@antazoey antazoey requested a review from dtdang August 23, 2024 15:24
dtdang
dtdang previously approved these changes Aug 23, 2024
@antazoey antazoey merged commit 151548b into ApeWorX:main Aug 23, 2024
16 checks passed
@antazoey antazoey deleted the fix/forked-provider-added-to-non-forked-custom-network branch August 23, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants