Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show nicer errors during bad network choices #2234

Merged
merged 3 commits into from
Aug 22, 2024

Conversation

antazoey
Copy link
Member

What I did

when the ecosystem, network, or provider were slightly off, it did not show me the nice message but instead told me to figure it out (rude!)

we were already getting the nice message earlier so this was an easy fix.

How I did it

leverage existing error message

How to verify it

ape console --network etheruem:local:test
ape console --network ethereum:loocal:test
ape console --network ethereum:local:teest

Checklist

  • All changes are completed
  • New test cases have been added
  • Documentation has been updated

@antazoey antazoey changed the title feat: show the nicer errors during bad network choices feat: sho nicer errors during bad network choices Aug 22, 2024
@antazoey antazoey changed the title feat: sho nicer errors during bad network choices feat: show nicer errors during bad network choices Aug 22, 2024
@antazoey antazoey enabled auto-merge (squash) August 22, 2024 17:23
@antazoey antazoey merged commit 6d9a0a3 into ApeWorX:main Aug 22, 2024
16 checks passed
@antazoey antazoey deleted the feat/better-network-not-found-err branch August 22, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants