fix: skip trace contract-logic errors during proxy-detection and more error-handling in eth_call #2207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antazoey
changed the title
fubuloubu
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Background: The failing call in the test in the linked issue was actually from a proxy-check on the contract, and not one the actual project's contract logic.
fix: handle recursion error in getting a contract type when eth call fails
BUT that was actually not the main problem (but still was good to fix).
The main problem is that tracing-features, including the intense exception handling one expects from failed calls, should be skipped altogether for proxy checks, and the mostly were thankfully except in this one spot.
perf: The fixing of this bug should be a rather nice performance upgrade because this means before, all failed proxy checks were fetching contract-types and preparing traces (not calling trace RPCs but doing everything else but)
fixes: #2206
How I did it
How to verify it
Checklist