refactor: share hex-related validators #2203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antazoey
commented
Aug 2, 2024
| gas_limit: Optional[int] = Field(default=None, alias="gas") | ||
| nonce: Optional[int] = None # NOTE: `Optional` only to denote using default behavior | ||
| value: int = 0 | ||
| gas_limit: Optional[HexInt] = Field(default=None, alias="gas") |
There was a problem hiding this comment.
note, these are not breaking changes (I added a test to make sure).
HexInt is only an annotated int for Pydantic, doesn't change any serialization types or even anything the API is going to compare about.
I added a test just in case in test_transaction to prove this!
fubuloubu
previously approved these changes
Aug 2, 2024
fubuloubu
previously approved these changes
Aug 5, 2024
There was a problem hiding this comment.
This is interesting:
https://peps.python.org/pep-0593/#aliases-concerns-over-verbosity
antazoey
force-pushed
the
refactor/hex-int-validation
branch
from
9bf1df4
to
d0c4da6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
noticed bugs and also lack of decent use of annotated-validators for hex-to-int situations, so made
HexIntfor that - likely will end up ineth-pydantic-typesafter @bitwise-constructs work is complete there.also had to delete some unnecessary validators for hex-str and hexbytes as it happens automatically when using those types.
note, did this originally because there was a regression i think with a recent merge validating BlobReceipts, somehow it occasionally go a hex-str for an int there and I was going to add the validator but I am getting tired of repeating this validator everywhere, hence HexInt's birthday
How to verify it
things still work (only better in the case of Blob receipts)!
Checklist