Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow local node to connect without HTTP #2201

Merged
merged 2 commits into from
Aug 2, 2024

Conversation

antazoey
Copy link
Member

@antazoey antazoey commented Aug 2, 2024

What I did

a miss, unable to use IPC or WS alone without HTTP

How I did it

make http uri optional in a helper method

How to verify it

node:
  ethereum:
    local:
      uri: $HOME/.ape/node/geth.ipc

Checklist

  • All changes are completed
  • New test cases have been added
  • Documentation has been updated

@antazoey antazoey changed the title fix: allow local node to connect without HTT fix: allow local node to connect without HTTP Aug 2, 2024
@antazoey antazoey requested a review from fubuloubu August 2, 2024 15:51
@antazoey
Copy link
Member Author

antazoey commented Aug 2, 2024

crazy, this even works with wss on mainnet:

INFO: Connecting to existing Geth node at wss://eth-mainnet.g.alchemy.com/[hidden].

In [1]: 

edit, somehow even get_block work! But it already has the txns filled out, a bit different.

@antazoey antazoey merged commit 9e211ab into ApeWorX:main Aug 2, 2024
17 checks passed
@antazoey antazoey deleted the feat/allow-no-http branch August 2, 2024 16:01
@fubuloubu
Copy link
Member

crazy, this even works with wss on mainnet:

INFO: Connecting to existing Geth node at wss://eth-mainnet.g.alchemy.com/[hidden].

In [1]: 

edit, somehow even get_block work! But it already has the txns filled out, a bit different.

yeah you can do those methods w/ websockets, just not preferrable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants