fix: threading applications using ape #1941
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Add signal handling for applications that use Ape using threads, this could be APIs, streamlit applications and prefect flows
fixes: #1164
How I did it
Checked if we are running in the main thread or not, if we are signaling is applied as usual, otherwise it won't be applied. This means more traceback for threaded applications but it will work.
How to verify it
Previously
ape
fails at import time due to signalling failing to be achieved on a child thread.Running the following script without the change will result in an error
ValueError: signal only works in main thread of the main interpreter
:Once the change is applied
ape
is successfully loadedChecklist