test: fix test causing flaky fail #1914
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
noticed last merge to main failed,
realized the test was not accurately testing something...
How I did it
ensure deployments set in config so we know we are reading the config deployment, which will always be at index 0
test was flakey because sometimes the deploy was at index 0 with no config deployments
this test got messed up like last PR when we could no longer deploy empties.
How to verify it
Checklist