fix: array of structs or tuples when only 1 element would be weird #1900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antazoey
force-pushed
the
fix/array-tuple-mixups
branch
from
4938128
to
0371066
Compare
fubuloubu
approved these changes
Jan 31, 2024
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
fixes a bug from Discord when if you have a func return an array of a single struct, it would be all funky and not at all like if 2 structs for example.
Also fixes the issue where arrays of structs were tuples unlike arrays of addresses or other types, which were lists. now arrays are always lists.
How I did it
Squeeze in some handling without breaking anything.
How to verify it
Checklist