Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ecosystem-level default in config for local gas limit #1878

Merged
merged 1 commit into from
Jan 23, 2024

Conversation

antazoey
Copy link
Member

What I did

this helps Arbitrum utilize the new base class and others who may change the default utilize the base class

class ArbitrumConfig(BaseEthereumConfig):
    DEFAULT_TRANSACTION_TYPE: ClassVar[int] = EthTransactionType.STATIC.value
    DEFAULT_LOCAL_GAS_LIMIT: ClassVar[GasLimit] = LOCAL_GAS_LIMIT
    mainnet: NetworkConfig = _create_config()
    goerli: NetworkConfig = _create_config()
    sepolia: NetworkConfig = _create_config()

see Arby PR: ApeWorX/ape-arbitrum#27

How I did it

classvar default

How to verify it

Checklist

  • All changes are completed
  • New test cases have been added
  • Documentation has been updated

@antazoey
Copy link
Member Author

This is the last PR I need to get custom networks config working across all our L2 plugins

@antazoey antazoey enabled auto-merge (squash) January 23, 2024 15:49
@antazoey antazoey merged commit 7959bb8 into ApeWorX:main Jan 23, 2024
15 checks passed
@antazoey antazoey deleted the feat/local-def-gaslmt branch January 23, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants