Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: decoding of receipt data from Etherscan #1875

Merged
merged 3 commits into from
Jan 22, 2024

Conversation

mikeshultz
Copy link
Member

What I did

Fixes an issue seen in ape-etherscan CI when decoding receipt data form Etherscan.

How I did it

Type conversion

How to verify it

Checklist

  • All changes are completed
  • New test cases have been added
  • Documentation has been updated

@mikeshultz mikeshultz added the category: bug Something isn't working label Jan 20, 2024
@mikeshultz mikeshultz self-assigned this Jan 20, 2024
fubuloubu
fubuloubu previously approved these changes Jan 20, 2024
antazoey
antazoey previously approved these changes Jan 22, 2024
Copy link
Member

@antazoey antazoey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tests/functional/test_ecosystem.py Outdated Show resolved Hide resolved
@mikeshultz mikeshultz dismissed stale reviews from antazoey and fubuloubu via 443eabf January 22, 2024 17:36
@mikeshultz mikeshultz enabled auto-merge (squash) January 22, 2024 21:11
@mikeshultz mikeshultz merged commit f010ffb into ApeWorX:main Jan 22, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants