-
-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Adjust SignatureError
with helpful tip on including sender=
tx kwarg
#1826
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To lessen the chance of providing wrong information, we could conditionally append the new suffix if and only if self.sender
is falsey
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@miohtama what do you think of the commit I added?
SignatureError
with helpful tip on including sender=
tx kwarg
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with modification that @antazoey added
… tx kwarg (ApeWorX#1826) Co-authored-by: Juliya Smith <jules@apeworx.io>
What I did
A developer experience enhancement.
When doing a transaction with Ape, if you forget
sender
parameter you get an unhelpful error message.Adding a help tip for
SignatureError
error message to hint to the user what's probably wrong:How I did it
Better error message.
How to verify it
Checklist