Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: improve error message when geth binary is not found #1809

Merged
merged 1 commit into from
Jan 3, 2024

Conversation

antazoey
Copy link
Member

@antazoey antazoey commented Jan 3, 2024

What I did

i think this would have prevented some confusion regarding a convo yesterday!
Thanks!

How I did it

How to verify it

Checklist

  • All changes are completed
  • New test cases have been added
  • Documentation has been updated

Copy link
Member

@mikeshultz mikeshultz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Def an improvement. 👍



def test_geth_not_found():
bin_name = "__NOT_A_REAL_EXECUTABLE_HOPEFULLY__"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol

@antazoey antazoey merged commit 6555fa2 into ApeWorX:main Jan 3, 2024
15 checks passed
@antazoey antazoey deleted the docs/improve-geth-err branch January 3, 2024 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants