fix: decoding issues that affect tracing features such as coverage #1803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antazoey
force-pushed
the
fix/decoding-issues
branch
from
75a55ca
to
5df6e69
Compare
antazoey
commented
Jan 3, 2024
| raise DecodingError(str(err)) from err | ||
| else: | ||
| # Use all zeroes. | ||
| vm_return_values = tuple([0 for _ in output_types_str_ls]) |
There was a problem hiding this comment.
it seems like the user is getting hardhat to give them empty bytes for a 0 return in some weird case that i havent reproduced
antazoey
commented
Jan 3, 2024
| raise DecodingError(str(err)) from err | ||
| if raw_data: | ||
| try: | ||
| vm_return_values = decode(output_types_str_ls, raw_data, strict=False) |
There was a problem hiding this comment.
second change: use strict=False here to see if that resolves the problem. I remember having to do this somewhere else because of node oddities (probably hardhat!)
fubuloubu
approved these changes
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
maybe resolves #1777
How to verify it
Checklist